Fix regression related to Windows CLI installer#2153
Merged
fredrikekelund merged 1 commit intotrunkfrom Dec 1, 2025
Merged
Conversation
Contributor
📊 Performance Test ResultsComparing b1f78bb vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
epeicher
approved these changes
Nov 28, 2025
| } ); | ||
|
|
||
| /** | ||
| * Windows implementation of CLI installation manager |
Contributor
There was a problem hiding this comment.
👍 The comment is almost the name of the class 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
In #2041, we changed the CLI installer's behavior on Windows so that it no longer installs automatically when the app starts. Users can now install the CLI through the Studio settings modal.
Unfortunately, my PR also introduced a regression, which is that the
%LOCALAPPDATA%\studio\bin\studio.batscript would no longer be updated automatically after Studio updates.The
%LOCALAPPDATA%\studiodirectory on Windows is structured so that theresourcesdirectory lives inside a versioned directory. For example, I have both%LOCALAPPDATA%\studio\app-1.6.4and%LOCALAPPDATA%\studio\app-1.6.5on my machine. Every time the app updates, a new directory is created, and we need to update the%LOCALAPPDATA%\studio\bin\studio.batfile to point to the newest directory (see #1152 for the original implementation).Testing Instructions
Code review should suffice
Pre-merge Checklist