Studio: Sync size calculator ignores database when all files are selected#2199
Merged
katinthehatsite merged 4 commits intotrunkfrom Dec 5, 2025
Merged
Studio: Sync size calculator ignores database when all files are selected#2199katinthehatsite merged 4 commits intotrunkfrom
katinthehatsite merged 4 commits intotrunkfrom
Conversation
Contributor
📊 Performance Test ResultsComparing b5839a3 vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
gcsecsey
approved these changes
Dec 5, 2025
Contributor
gcsecsey
left a comment
There was a problem hiding this comment.
Thanks for improving this @katinthehatsite! 🙌
The changes look good to me and the calculation seems correct to me in all scenarios
CleanShot.2025-12-05.at.13.35.29.mp4
Contributor
|
I restarted the e2e tests because the failing |
Contributor
Author
Nice, thanks a lot 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Fixes STU-1104
Proposed Changes
This PR ensure that the database size selection is always correctly displayed in the sync modal.
Testing Instructions
SynctabSyncmodalPushbuttonPre-merge Checklist