-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Support for installing ripgrep with cargo-binstall #2298
Copy link
Copy link
Closed
Labels
enhancementAn enhancement to the functionality of the software.An enhancement to the functionality of the software.help wantedOthers are encouraged to work on this issue.Others are encouraged to work on this issue.rollupA PR that has been merged with many others in a rollup.A PR that has been merged with many others in a rollup.
Description
Metadata
Metadata
Assignees
Labels
enhancementAn enhancement to the functionality of the software.An enhancement to the functionality of the software.help wantedOthers are encouraged to work on this issue.Others are encouraged to work on this issue.rollupA PR that has been merged with many others in a rollup.A PR that has been merged with many others in a rollup.
Describe your feature request
cargo-binstall is a way to fetch precompiled binaries without the need to build from source. It is meant to speed up installing new cargo tools.
By default,
cargo-binstallwill look for GitHub releases artifacts, andripgrephas these. Unfortunately,cargo-generaterequires the version component to conform tov.*pattern, andripgrepdoesn't include thev.The easiest way to achieve the desired result would be to override this default by adding this to
Cargo.toml:(notice the lack of
vin the version component)If support for
cargo-binstallis deemed preferable, I'd be happy to land such PR and test that this solution works.Alternative
An alternative would be to change the naming conventions for the releases, but I think the above solution is more surgical and less interfering.