This repository was archived by the owner on Apr 18, 2026. It is now read-only.
Bump rubocop version to 1.48.1.#500
Merged
Merged
Conversation
- Style/SymbolArray - Style/WordArray
- Layout/MultilineMethodCallBraceLayout - Layout/MultilineMethodDefinitionBraceLayout - Layout/EmptyLineAfterMagicComment - Layout/EmptyLineAfterGuardClause - Layout/EmptyLinesAroundExceptionHandlingKeywords - Layout/MultilineArrayBraceLayout - Layout/ClosingParenthesisIndentation - Layout/FirstArrayElementIndentation
- Layout/ClosingHeredocIndentation - Layout/FirstParameterIndentation - Layout/ClosingParenthesisIndentation
- Layout/BeginEndAlignment. - Layout/BlockAlignment - Layout/IndentationWidth
- Layout/ClosingHeredocIndentation - Naming/HeredocDelimiterCase - Naming/HeredocDelimiterNaming
- Naming/MethodParameterName - Naming/VariableNumber
- Style/MissingRespondToMissing - Lint/MissingSuper
Also fix signature of BaseCounter#increment.
Also update statusz test to check the uptime string.
LujieDuan
approved these changes
Mar 17, 2023
LujieDuan
left a comment
There was a problem hiding this comment.
LGTM!
Thanks for having each fix in its own commit - that makes verifying each enforcement very easy.
The presubmit is failed as rubocop=1.48.1 requires ruby >= 2.6. Should we modify the test matrix in this PR?
Contributor
Author
Good point. Fixed. |
fd9c555 to
30ae7b1
Compare
Closed
This was referenced Mar 31, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix all of the new warnings.
b/272577695.
See also GoogleCloudPlatform/fluent-plugin-detect-exceptions#101.