Skip to content

Support disabling Cloud Run URL - populate CloudRunServiceReady even if URL is not there #9522

@menahyouyeah

Description

@menahyouyeah

Expected behavior

Skaffold populates the CloudRunReadyEvent struct when a deployment is successful to Cloud Run when the following annotations have been added to the Cloud Run manifest:

run.googleapis.com/default-url-disabled:true
run.googleapis.com/launch-stage: BETA

This is using a new feature from Cloud Run.

Actual behavior

Because of this line, if the URL is not populated, reportSuccess() does not populate CloudRunServiceReady.

Information

apiVersion: serving.knative.dev/v1
kind: Service
metadata:
name: deploy-run-service-dev
annotations:
run.googleapis.com/launch-stage: 'BETA'
run.googleapis.com/default-url-disabled: 'true'
spec:
template:
spec:
containers:
- image: my-app-image

Steps to reproduce the behavior

Try to deploy a Cloud Run service using the above manifest. To repro, use this quick start with the service yaml modified per the above.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions