Skip to content

feat: add kaniko.imagePullSecret config option for pulling kaniko images from private registry #9183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dherges wants to merge 0 commits into from
Closed

feat: add kaniko.imagePullSecret config option for pulling kaniko images from private registry #9183

dherges wants to merge 0 commits into from

Conversation

@dherges
Copy link
Contributor

@dherges dherges commented Nov 21, 2023 •
edited
Loading

Fixes: #9170
Related: n/a
Merge before/after: n/a

Description

add a new config option kaniko.imagePullSecret

Do you reach out if there is anything missing?

@dherges dherges requested a review from a team as a code owner November 21, 2023 07:48
@dherges dherges requested a review from bendory November 21, 2023 07:48
@dherges dherges changed the title feat: feat: add kaniko.imagePullSecret config option for pulling kaniko images from private registry Nov 21, 2023
@ericzzzzzzz
Copy link
Contributor

ericzzzzzzz commented Nov 21, 2023

Hi @dherges Thank you for the contribution , could you please have a separate pr just for the config schema change ? Thanks

@dherges
Copy link
Contributor Author

dherges commented Nov 21, 2023

Hi @dherges Thank you for the contribution , could you please have a separate pr just for the config schema change ? Thanks

Do you mean the hack/new-version.sh + the 2 lines added to config.go?

@ericzzzzzzz
Copy link
Contributor

ericzzzzzzz commented Nov 21, 2023

Hi @dherges Thank you for the contribution , could you please have a separate pr just for the config schema change ? Thanks

Do you mean the hack/new-version.sh + the 2 lines added to config.go?
There are two commits in this pr, you should split this pr into two pr, one for new config schema generation, another for the business logic change. Please follow the guide here , https://github.com/GoogleContainerTools/skaffold/blob/main/DEVELOPMENT.md#making-a-config-change , thanks.

@dherges dherges mentioned this pull request Nov 23, 2023
Closed
@dherges dherges closed this Nov 23, 2023
@dherges dherges mentioned this pull request Nov 23, 2023
Closed
@dherges
Copy link
Contributor Author

dherges commented Nov 23, 2023

Hi @dherges Thank you for the contribution , could you please have a separate pr just for the config schema change ? Thanks

Do you mean the hack/new-version.sh + the 2 lines added to config.go?
There are two commits in this pr, you should split this pr into two pr, one for new config schema generation, another for the business logic change. Please follow the guide here , https://github.com/GoogleContainerTools/skaffold/blob/main/DEVELOPMENT.md#making-a-config-change , thanks.

I closed this.

For the config option: #9190

The implementation #9191

@alphanota alphanota mentioned this pull request Jan 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bendory bendory Awaiting requested review from bendory bendory was automatically assigned from GoogleContainerTools/skaffold-team

Assignees

No one assigned

Labels

size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

kaniko in-cluster build: pulling kaniko images from private registry w/ image pull secret

2 participants

@dherges @ericzzzzzzz