chore: bump go version to 1.24.1 #9772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/x509 package appears to have changes that made older pem files un-parseable.
mattsanta
previously approved these changes
Apr 1, 2025
plumpy
reviewed
Apr 1, 2025
Collaborator
plumpy
left a comment
There was a problem hiding this comment.
There are (sadly) lots of other places where we hardcode the Go version used. Could you look through all the places we changed during the last upgrade and see if they should be modified too?
https://github.com/GoogleContainerTools/skaffold/pull/9571/files
plumpy
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades go to latest version 1.24.1, and fixes some dependencies that break on go 1.24
golanci-lint: Upgrade to a 1.24 compatible version.
logrus analyzer: Upgrade the deps in the log analyzer module
Re-generate the certificates used as testdata in the TestPortForward tests and add a readme in the tesdata linking to instructions on how to generate those files.
Comparing a sync.Mutex field breaks some tests because an unexported field in the Mutex struct, it can't be added as an AllowUnexported option (because its in the "internal/sync" package) so I just removed the sync.Mutex comparison.