fix: use print-access-token to allow iam impersonation #9841
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Summary of Changes
Hello @timtlchen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a critical authentication issue within the GCP integration, specifically concerning IAM service account impersonation. By migrating from gcloud auth print-identity-token to gcloud auth print-access-token, the system can now correctly acquire tokens for impersonated identities, ensuring that operations requiring such impersonation function as intended. This change also necessitated minor adjustments to the internal token handling and associated tests to accommodate the new command's output format.
Highlights
- IAM Impersonation Fix: The core change involves switching the
gcloudcommand used for obtaining authentication tokens fromprint-identity-tokentoprint-access-token. This resolves an issue whereprint-identity-tokencould not correctly retrieve tokens for impersonated service accounts, thus enabling proper IAM impersonation support. - Token Structure Adaptation: The internal
tokenstruct and its associated JSON unmarshalling logic have been updated to align with the simpler output format provided bygcloud auth print-access-token. This new format returns a singletokenfield, eliminating the need foraccess_token,id_token, andtoken_expiryfields in the parsed JSON. - Test Suite Alignment: Corresponding unit tests in
auth_test.gohave been updated. This includes modifying the mockgcloudcommand calls and adjusting the expected JSON output to reflect the newprint-access-tokenbehavior and its simplified token structure.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The code changes replace the print-identity-token command with print-access-token to correctly print the impersonated service account's token. The review identified a typo in the error message and a redundant command execution in the test.
|
@timtlchen Thanks for this fix! |
Fixes: #9839
Description
The print-identity-token can only print the token of the GCP default authentication's token, but not the token for the impersonated service account. print-access-token can correctly print the impersonated service account's token.