chore: upgrade to Go 1.25.0 #9859
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @menahyouyeah, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request upgrades the Go version used in the deploy/skaffold/Dockerfile.deps from Go 1.24.2 to Go 1.24.6. This ensures that the build environment leverages the latest stable Go release, incorporating bug fixes, security updates, and performance improvements available in version 1.24.6.
Highlights
- Go Version Upgrade: The Go version used for building dependencies in deploy/skaffold/Dockerfile.deps has been updated from golang:1.24.2 to golang:1.24.6.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request upgrades the Go version used in the build process to 1.24.6. The change is straightforward and beneficial. I've added one suggestion to further improve the security and reproducibility of the Docker build by pinning the base image to its content digest.
deploy/skaffold/Dockerfile.deps
Outdated
| apt-transport-https && \ | ||
| rm -rf /var/lib/apt/lists/* | ||
| COPY --from=golang:1.24.2 /usr/local/go /usr/local/go | ||
| COPY --from=golang:1.24.6 /usr/local/go /usr/local/go |
There was a problem hiding this comment.
For improved security and build reproducibility, it's a good practice to pin the image to its digest. This ensures you are always using the exact same image and protects against tag mutability, where the 1.24.6 tag could be updated to point to a different image. This aligns with the practice of checksumming downloaded tools seen elsewhere in this file.
COPY --from=golang:1.24.6@sha256:0e2602357c3162391580e033959b3d37422b49864539818e6c382a0435304771 /usr/local/go /usr/local/go
done |
chore: upgrade to Go 1.25.0