Skip to content

chore: upgrade golang to 1.25.4 #9909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
menahyouyeah merged 2 commits into from
Nov 13, 2025
Merged

chore: upgrade golang to 1.25.4 #9909

menahyouyeah merged 2 commits into from
Nov 13, 2025

Conversation

@mattsanta
Copy link
Contributor

@mattsanta mattsanta commented Nov 13, 2025 •
edited
Loading

Upgrading golang version in preparation for new Skaffold release.

@mattsanta mattsanta requested a review from a team as a code owner November 13, 2025 14:08
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Nov 13, 2025

Summary of Changes

Hello @mattsanta, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a routine update of the Go programming language version used within the project. By upgrading to Go 1.25.4, the project benefits from the latest stability, performance enhancements, and security patches provided by the Go team, ensuring the development environment and build processes are current.

Highlights

  • Go Version Upgrade: The project's Go language version has been updated from 1.25.3 to 1.25.4.
  • Dockerfile Dependency Update: The Dockerfile.deps now pulls the golang:1.25.4 image for building dependencies.
  • Go Module File Adjustment: The go.mod file has been modified to reflect the new Go version requirement of 1.25.4.
Ignored Files
  • Ignored by pattern: .github/workflows/** (5)
    • .github/workflows/linters-checks.yml
    • .github/workflows/unit-tests-darwin.yml
    • .github/workflows/unit-tests-linux.yml
    • .github/workflows/unit-tests-windows.yml
    • .github/workflows/verify-examples.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 13, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the Go version to 1.25.4. The changes in go.mod and deploy/skaffold/Dockerfile.deps are correct and align with the goal of the PR. For consistency across the repository, I recommend also updating the Go version in other parts of the codebase. Specifically, hack/tools/go.mod is still using go 1.24.1, and hack/proto/Dockerfile is using golang:1.24.5. It would be beneficial to update these to 1.25.4 as well. After updating hack/tools/go.mod, please remember to run go mod tidy in that directory.

@menahyouyeah menahyouyeah merged commit 719da28 into GoogleContainerTools:main Nov 13, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@menahyouyeah menahyouyeah menahyouyeah approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mattsanta @menahyouyeah