Skip to content

Remove deprecated whitespace for Clang 20.1.0 #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2025
Merged

Remove deprecated whitespace for Clang 20.1.0 #869

merged 1 commit into from
Mar 2, 2025

Conversation

@jonkeane
Copy link
Contributor

@jonkeane jonkeane commented Mar 2, 2025

Resolves #868

@HowardHinnant HowardHinnant merged commit b8d166b into HowardHinnant:master Mar 2, 2025
@HowardHinnant
Copy link
Owner

HowardHinnant commented Mar 2, 2025

Thanks, I was unaware of this issue.

@eddelbuettel
Copy link
Contributor

eddelbuettel commented Mar 6, 2025

If you grep recursively (I like ag i.e. the silversearcher) it comes up in a few more places:

-*- mode: ag; default-directory: "~/git/rcppdate/inst/include/" -*-
Ag started at Wed Mar  5 19:43:58

ag --literal --group --line-number --column --color --color-match 30\;43 --color-path 1\;32 --smart-case --stats -- operator\ \"\" .
File: solar_hijri.h
795:29:CONSTCD11 solar_hijri::day  operator "" _d(unsigned long long d) NOEXCEPT;
796:29:CONSTCD11 solar_hijri::year operator "" _y(unsigned long long y) NOEXCEPT;
1367:1:operator "" _d(unsigned long long d) NOEXCEPT
1375:1:operator "" _y(unsigned long long y) NOEXCEPT

File: iso_week.h
750:1:operator "" _y(unsigned long long y) NOEXCEPT
758:1:operator "" _w(unsigned long long wn) NOEXCEPT

File: date.h
966:22:CONSTCD11 date::day  operator ""_d(unsigned long long d) NOEXCEPT;
967:22:CONSTCD11 date::year operator ""_y(unsigned long long y) NOEXCEPT;
1975:1:operator ""_d(unsigned long long d) NOEXCEPT
1983:1:operator ""_y(unsigned long long y) NOEXCEPT

File: julian.h
761:24:CONSTCD11 julian::day  operator "" _d(unsigned long long d) NOEXCEPT;
762:24:CONSTCD11 julian::year operator "" _y(unsigned long long y) NOEXCEPT;
1336:1:operator "" _d(unsigned long long d) NOEXCEPT
1344:1:operator "" _y(unsigned long long y) NOEXCEPT

File: islamic.h
761:25:CONSTCD11 islamic::day  operator "" _d(unsigned long long d) NOEXCEPT;
762:25:CONSTCD11 islamic::year operator "" _y(unsigned long long y) NOEXCEPT;
1342:1:operator "" _d(unsigned long long d) NOEXCEPT
1350:1:operator "" _y(unsigned long long y) NOEXCEPT
18 matches
5 files contained matches
10 files searched
629036 bytes searched
0.003684 seconds

Ag finished at Wed Mar  5 19:43:58

This is from a CRAN package of mine that also vendors date.h but like @jonkeane I only got bitten so far by CRAN warning against date.h.

Happy to send a quick PR if you want one.

@eddelbuettel eddelbuettel mentioned this pull request Mar 6, 2025
Merged
@DavisVaughan DavisVaughan mentioned this pull request Mar 11, 2025
Merged
@BrewTestBot BrewTestBot mentioned this pull request May 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix identifier ... preceded by whitespace warnings in Clang 20.1.0

3 participants

@jonkeane @HowardHinnant @eddelbuettel