Skip to content

Commit 049648f

Browse files
titusfortnertitusfortner
committed
[rb] this code is swallowing data
1 parent 0106659 commit 049648f

2 files changed

Lines changed: 0 additions & 7 deletions

File tree

‎rb/lib/selenium/webdriver/remote/w3c_bridge.rb‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,9 +108,6 @@ def session_id
108108
end
109109

110110
def create_session(desired_capabilities)
111-
# TODO - Remove this when Mozilla fixes bug
112-
desired_capabilities[:browser_name] = 'firefox' if desired_capabilities[:browser_name] == 'Firefox'
113-
114111
resp = raw_execute :new_session, {}, {desiredCapabilities: desired_capabilities}
115112
@session_id = resp['sessionId']
116113
return W3CCapabilities.json_create resp['value'] if @session_id

‎rb/lib/selenium/webdriver/remote/w3c_capabilities.rb‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -96,10 +96,6 @@ def w3c?(opts = {})
9696
def json_create(data)
9797
data = data.dup
9898

99-
# Convert due to Remote Driver implementation
100-
data['browserVersion'] = data.delete('version') if data.key? 'version'
101-
data['platformName'] = data.delete('platform') if data.key? 'platform'
102-
10399
caps = new
104100
caps.browser_name = data.delete('browserName')
105101
caps.browser_version = data.delete('browserVersion')

0 commit comments

Comments
 (0)