Skip to content

Commit c9ecf8b

Browse files
davehuntdavehunt
committed
[py] Remove skips for Chrome < 16 in TestWebDriverSelectSupport
1 parent 38bafdd commit c9ecf8b

1 file changed

Lines changed: 0 additions & 14 deletions

File tree

‎py/test/selenium/webdriver/common/select_class_tests.py‎

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,6 @@ def testSelectDisabledByVisibleTextShouldThrowException(self, driver, pages):
9898
sel.select_by_visible_text('Bar')
9999

100100
def testSelectByIndexMultiple(self, driver, pages):
101-
if driver.capabilities['browserName'] == 'chrome' and int(driver.capabilities['version'].split('.')[0]) < 16:
102-
pytest.skip("deselecting preselected values only works on chrome >= 16")
103101
pages.load("formPage.html")
104102

105103
for select in [multiSelectValues1, multiSelectValues2]:
@@ -113,8 +111,6 @@ def testSelectByIndexMultiple(self, driver, pages):
113111
assert selected[j].text == select['values'][j]
114112

115113
def testSelectByValueMultiple(self, driver, pages):
116-
if driver.capabilities['browserName'] == 'chrome' and int(driver.capabilities['version'].split('.')[0]) < 16:
117-
pytest.skip("deselecting preselected values only works on chrome >= 16")
118114
pages.load("formPage.html")
119115

120116
for select in [multiSelectValues1, multiSelectValues2]:
@@ -128,8 +124,6 @@ def testSelectByValueMultiple(self, driver, pages):
128124
assert selected[j].text == select['values'][j]
129125

130126
def testSelectByVisibleTextMultiple(self, driver, pages):
131-
if driver.capabilities['browserName'] == 'chrome' and int(driver.capabilities['version'].split('.')[0]) < 16:
132-
pytest.skip("deselecting preselected values only works on chrome >= 16")
133127
pages.load("formPage.html")
134128

135129
for select in [multiSelectValues1, multiSelectValues2]:
@@ -149,8 +143,6 @@ def testDeselectAllSingle(self, driver, pages):
149143
Select(driver.find_element(By.NAME, select['name'])).deselect_all()
150144

151145
def testDeselectAllMultiple(self, driver, pages):
152-
if driver.capabilities['browserName'] == 'chrome' and int(driver.capabilities['version'].split('.')[0]) < 16:
153-
pytest.skip("deselecting preselected values only works on chrome >= 16")
154146
pages.load("formPage.html")
155147
for select in [multiSelectValues1, multiSelectValues2]:
156148
sel = Select(driver.find_element(By.NAME, select['name']))
@@ -176,8 +168,6 @@ def testDeselectByVisibleTextSingle(self, driver, pages):
176168
Select(driver.find_element(By.NAME, select['name'])).deselect_by_visible_text(select['values'][0])
177169

178170
def testDeselectByIndexMultiple(self, driver, pages):
179-
if driver.capabilities['browserName'] == 'chrome' and int(driver.capabilities['version'].split('.')[0]) < 16:
180-
pytest.skip("deselecting preselected values only works on chrome >= 16")
181171
pages.load("formPage.html")
182172
for select in [multiSelectValues1, multiSelectValues2]:
183173
sel = Select(driver.find_element(By.NAME, select['name']))
@@ -194,8 +184,6 @@ def testDeselectByIndexMultiple(self, driver, pages):
194184
assert selected[1].text == select['values'][2]
195185

196186
def testDeselectByValueMultiple(self, driver, pages):
197-
if driver.capabilities['browserName'] == 'chrome' and int(driver.capabilities['version'].split('.')[0]) < 16:
198-
pytest.skip("deselecting preselected values only works on chrome >= 16")
199187
pages.load("formPage.html")
200188
for select in [multiSelectValues1, multiSelectValues2]:
201189
sel = Select(driver.find_element(By.NAME, select['name']))
@@ -212,8 +200,6 @@ def testDeselectByValueMultiple(self, driver, pages):
212200
assert selected[1].text == select['values'][2]
213201

214202
def testDeselectByVisibleTextMultiple(self, driver, pages):
215-
if driver.capabilities['browserName'] == 'chrome' and int(driver.capabilities['version'].split('.')[0]) < 16:
216-
pytest.skip("deselecting preselected values only works on chrome >= 16")
217203
pages.load("formPage.html")
218204
for select in [multiSelectValues1, multiSelectValues2]:
219205
sel = Select(driver.find_element(By.NAME, select['name']))

0 commit comments

Comments
 (0)