Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## trunk #12194 +/- ##
==========================================
+ Coverage 56.56% 56.98% +0.41%
==========================================
Files 86 86
Lines 5450 5440 -10
Branches 223 226 +3
==========================================
+ Hits 3083 3100 +17
+ Misses 2144 2114 -30
- Partials 223 226 +3
☔ View full report in Codecov by Sentry. |
diemol
approved these changes
Jun 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added missing SafariOptions, and all the browser Service classes to the webdriver aliases.
Motivation and Context
We have required users to move parameters from WebDriver constructor to the Options or Service constructors. We should make it easier to reference the Service constructors. This will also make our documentation pages easier.