Skip to content

Extract original driver from decorated driver when Augmenting a driver - #12248

Merged
diemol merged 15 commits into
SeleniumHQ:trunkfrom
baflQA:extractOriginalDriver
Jun 28, 2023
Merged

Extract original driver from decorated driver when Augmenting a driver#12248
diemol merged 15 commits into
SeleniumHQ:trunkfrom
baflQA:extractOriginalDriver

Conversation

@baflQA

@baflQA baflQA commented Jun 23, 2023

Copy link
Copy Markdown
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Extract the original driver from the decorated driver.

Motivation and Context

When trying to use the Augmentor on a decorated driver, the extractRemoteWebDriver method will be executed infinitely.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

diemol
diemol reviewed Jun 23, 2023
View reviewed changes

@diemol diemol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR.

Is there a way we can reproduce the issue first to understand the fix? Maybe it can be added as a test?

@baflQA

baflQA commented Jun 24, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for this PR.

Is there a way we can reproduce the issue first to understand the fix? Maybe it can be added as a test?

I will be happy to add a test, once I'm finished with indexing the project 😂 it was running the whole night and crashed my IDE at some point...

@titusfortner

titusfortner commented Jun 25, 2023

Copy link
Copy Markdown
Member

Make sure you mark as excluded all the bazel-* directories and the build directory. InteliJ hates indexing Bazel generated things for some reason.

@baflQA
baflQA requested a review from diemol June 26, 2023 09:08
@baflQA

baflQA commented Jun 26, 2023

Copy link
Copy Markdown
Contributor Author

Make sure you mark as excluded all the bazel-* directories and the build directory. InteliJ hates indexing Bazel generated things for some reason.

That helped a lot! Thx

@titusfortner

titusfortner commented Jun 26, 2023

Copy link
Copy Markdown
Member

You have *no idea how long it took me to figure out what was causing the problem...

diemol
diemol requested changes Jun 27, 2023
View reviewed changes
Comment thread java/src/org/openqa/selenium/support/BUILD.bazel Outdated
Comment thread java/src/org/openqa/selenium/support/decorators/BUILD.bazel Outdated
@baflQA
baflQA requested a review from diemol June 27, 2023 20:13
diemol
diemol approved these changes Jun 28, 2023
View reviewed changes

@diemol diemol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @baflQA!

@diemol
diemol merged commit c49361a into SeleniumHQ:trunk Jun 28, 2023
@baflQA
baflQA deleted the extractOriginalDriver branch June 28, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diemol diemol diemol approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@baflQA @titusfortner @diemol