[py] moved ConnectionType class outside Mobile class to avoid nesting of classes - #12256
Merged
Conversation
… in remote/mobile.py
Member
|
It is a rather short class. Is this because the current state is not aligned with a Python style guide? I do not see what the benefit is. |
Contributor
Author
Normally we do have nested functions or classes only in case of decorators or in case of fixtures. But this is a normal class, so I have moved it out of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… in remote/mobile.py
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
I have moved
ConnectionTypeclass outsideMobileclass inremote/mobile.pyto avoid nesting of classes and for better readability.Motivation and Context
The class
ConnectionTypeis insideMobileclass, which is I felt bit confusing and hard to read. So I have moved the inner classConnectionTypeout ofMobileclass.Types of changes
Checklist