Skip to content

[py] removed un-necessary __init__ from driver_finder.py and selenium_manager.py - #12265

Merged
diemol merged 3 commits into
SeleniumHQ:trunkfrom
sandeepsuryaprasad:init_fix
Jun 27, 2023
Merged

[py] removed un-necessary __init__ from driver_finder.py and selenium_manager.py#12265
diemol merged 3 commits into
SeleniumHQ:trunkfrom
sandeepsuryaprasad:init_fix

Conversation

@sandeepsuryaprasad

Copy link
Copy Markdown
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Removed __init__ in driver_finder.py and selenium_manager.py.

Motivation and Context

__init__ was not necessary in DriverFinder and SeleniumManger classes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@diemol diemol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @sandeepsuryaprasad!

@diemol
diemol merged commit 7c40c11 into SeleniumHQ:trunk Jun 27, 2023
@sandeepsuryaprasad
sandeepsuryaprasad deleted the init_fix branch November 24, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants