Skip to content

[py] moved all ie options to custom descriptors. - #12283

Merged
AutomatedTester merged 1 commit into
SeleniumHQ:trunkfrom
sandeepsuryaprasad:ie-options-optimization
Jun 28, 2023
Merged

[py] moved all ie options to custom descriptors.#12283
AutomatedTester merged 1 commit into
SeleniumHQ:trunkfrom
sandeepsuryaprasad:ie-options-optimization

Conversation

@sandeepsuryaprasad

Copy link
Copy Markdown
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Moved all ie options from properties to custom descriptor.

Motivation and Context

  • There are around 17 pairs of getters and setters in ie options.
  • Moved all properties to one single custom descriptor. There by avoiding code repetition.

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have added tests to cover my changes.
  • All new and existing tests passed.

@AutomatedTester
AutomatedTester merged commit 5ba17d6 into SeleniumHQ:trunk Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants