Add supports for list-of-table options - #12363
Merged
Merged
Conversation
sbabcoc
force-pushed
the
pr/add-list-of-array-support
branch
from
July 13, 2023 19:02
314bbb3 to
26e68f1
Compare
8 tasks
sbabcoc
force-pushed
the
pr/add-list-of-array-support
branch
from
July 13, 2023 21:10
26e68f1 to
3c9a566
Compare
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## trunk #12363 +/- ##
=======================================
Coverage 57.28% 57.28%
=======================================
Files 86 86
Lines 5333 5333
Branches 193 193
=======================================
Hits 3055 3055
Misses 2085 2085
Partials 193 193 ☔ View full report in Codecov by Sentry. |
sbabcoc
force-pushed
the
pr/add-list-of-array-support
branch
from
July 14, 2023 21:25
3c9a566 to
d233db6
Compare
diemol
reviewed
Jul 15, 2023
sbabcoc
force-pushed
the
pr/add-list-of-array-support
branch
from
July 16, 2023 01:55
d233db6 to
b380ed2
Compare
sbabcoc
force-pushed
the
pr/add-list-of-array-support
branch
from
July 16, 2023 17:32
b380ed2 to
1c2aac1
Compare
diemol
approved these changes
Jul 16, 2023
diemol
left a comment
Member
There was a problem hiding this comment.
Thank you!
(Test failure is unrelated to this change).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently our json based configurations does not
support List of Maps (this is supported on Toml
format)
Issue details are available in
https://groups.google.com/g/selenium-developers/c/_UYMd3ZjQ0M
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
More details on this issue is available in https://groups.google.com/g/selenium-developers/c/_UYMd3ZjQ0M
Motivation and Context
To support list of maps when dealing with json config files for Grid.
Types of changes
Checklist