Skip to content

[py] __init__ in chromium/remote_connection.py is now more readable. - #12367

Merged
diemol merged 2 commits into
SeleniumHQ:trunkfrom
sandeepsuryaprasad:pref-fix
Jul 21, 2023
Merged

[py] __init__ in chromium/remote_connection.py is now more readable.#12367
diemol merged 2 commits into
SeleniumHQ:trunkfrom
sandeepsuryaprasad:pref-fix

Conversation

@sandeepsuryaprasad

@sandeepsuryaprasad sandeepsuryaprasad commented Jul 14, 2023

Copy link
Copy Markdown
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Made __init__ method in chromium/remote_connection.py more readable by moving all remote commands to an internal method _remote_commands.

Motivation and Context

  • Moved all remote commands in __init__ of chromium/remote_connection.py to an internal method _remote_commands
  • Now the constructor looks more readable as all the commands are moved to separate method.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have added tests to cover my changes.
  • All new and existing tests passed.

@diemol diemol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @sandeepsuryaprasad!

@diemol
diemol merged commit 44d202c into SeleniumHQ:trunk Jul 21, 2023
@sandeepsuryaprasad
sandeepsuryaprasad deleted the pref-fix branch November 24, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants