[dotnet] add browser output from selenium manager to options - #12405
Merged
Conversation
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## trunk #12405 +/- ##
=======================================
Coverage 56.99% 56.99%
=======================================
Files 86 86
Lines 5336 5336
Branches 193 193
=======================================
Hits 3041 3041
Misses 2102 2102
Partials 193 193 ☔ View full report in Codecov by Sentry. |
titusfortner
force-pushed
the
dotnet_sm_browser
branch
from
July 24, 2023 02:20
c2a0a75 to
eb56c27
Compare
titusfortner
force-pushed
the
dotnet_sm_browser
branch
from
July 24, 2023 15:53
eb56c27 to
05f4f11
Compare
titusfortner
marked this pull request as ready for review
July 24, 2023 16:06
titusfortner
force-pushed
the
dotnet_sm_browser
branch
from
July 24, 2023 18:12
c3a4cca to
ffae623
Compare
diemol
approved these changes
Jul 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Draft because:
waiting on [rust] Download latest version of Chrome for Testing (#11676) #12353I should test this on windowsDescription
Sets browser location on Options class if supported (Chrome, Edge, Firefox only)
browserVersionMotivation and Context
Notes
This is probably not the right way to do this, but it is the easy way. Store the value in the class, mark it not implemented if not implemented and get / set as necessary.