[rust] Use latest browser from cache when browser path is not discovered - #13283
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## trunk #13283 +/- ##
=======================================
Coverage 57.99% 57.99%
=======================================
Files 88 88
Lines 5338 5338
Branches 224 224
=======================================
Hits 3096 3096
Misses 2018 2018
Partials 224 224 ☔ View full report in Codecov by Sentry. |
diemol
approved these changes
Dec 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR allows Selenium Manager to discover the latest browser version available in cache if there is some problem (e.g., the browser version cannot be discovered using online endpoints).
Motivation and Context
Currently, there is a fallback to get the latest driver version in the cache when some error happens. This PR do the same, but for browsers. It will allow to avoid problems like the reported in #13238 (i.e., a temporal glitch in the Edge endpoint response).
Types of changes
Checklist