[java] Selenium Manager generates output from argument list - #13385
Merged
Conversation
Member
Author
|
Do I need to deprecate, or can I just remove because the class is annotated as |
Member
Author
|
and should we also rename |
diemol
approved these changes
Jan 2, 2024
diemol
left a comment
Member
There was a problem hiding this comment.
I would delete since it is market as beta.
My only concern is that we do not have enough tests to properly verify this refactor. Haven't we had the situation in the past where moving some arguments around ended up in some bugs?
Member
Author
|
Tests are a good idea. 😂 |
bonigarcia
reviewed
Jan 2, 2024
titusfortner
force-pushed
the
sm_thin_java
branch
from
January 7, 2024 18:45
04b22d3 to
6499437
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## trunk #13385 +/- ##
=======================================
Coverage 58.82% 58.82%
=======================================
Files 86 86
Lines 5272 5272
Branches 219 219
=======================================
Hits 3101 3101
Misses 1952 1952
Partials 219 219 ☔ View full report in Codecov by Sentry. |
diemol
requested changes
Jan 8, 2024
titusfortner
force-pushed
the
sm_thin_java
branch
3 times, most recently
from
January 11, 2024 21:59
b5cf270 to
af7d1fc
Compare
Member
Author
|
Ok, refactored along the lines of Simon's suggestions, added tests, they pass, I'm generally happy with the naming I think right now, and it's matching Ruby & Python PRs. This can be merged once approved. |
diemol
reviewed
Jan 12, 2024
titusfortner
force-pushed
the
sm_thin_java
branch
from
January 19, 2024 21:15
af7d1fc to
5ad09a4
Compare
…f capabilities instance
diemol
approved these changes
Mar 25, 2024
Contributor
CI Failure Feedback(Checks updated until commit 0a296f0)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR: where Configuration options
See more information about the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DriverFinderconvert theCapabilitiesinto the arguments required by Selenium Manager binarygetPath()methodMotivation and Context
getPath()is no longer an accurate oneUpdates
Updates:
getPath()togetResult()inDriverFinderas well. The name isn't great, but it is the name of the current class and I can't think of anything better. (getPaths()?SeleniumManagerOutput()?)browserVersionis set tonullin the 3 applicable driver classes instead of DriverFinder, and only if there is a browser path.Status
getResult()?