Skip to content

[java] Deprecate ContextAware interface - #13405

Merged
diemol merged 1 commit into
SeleniumHQ:trunkfrom
valfirst:fix-leftovers-of-context-endpoints-removal
Jan 7, 2024
Merged

[java] Deprecate ContextAware interface#13405
diemol merged 1 commit into
SeleniumHQ:trunkfrom
valfirst:fix-leftovers-of-context-endpoints-removal

Conversation

@valfirst

@valfirst valfirst commented Jan 7, 2024

Copy link
Copy Markdown
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Context management endpoints were removed in 1b66415, so it seems ContextAware interface becomes redundant.

Motivation and Context

Open questions:

  • should ContextAware interface be deprecated or removed?
  • should NoSuchContextException be deprecated/removed as well?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@diemol
diemol merged commit a5be5b6 into SeleniumHQ:trunk Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants