Explicitly export Select and WebDriverWait from selenium.webdriver.support.ui - #13491
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## trunk #13491 +/- ##
=======================================
Coverage 58.48% 58.48%
=======================================
Files 86 86
Lines 5270 5271 +1
Branches 220 220
=======================================
+ Hits 3082 3083 +1
Misses 1968 1968
Partials 220 220 ☔ View full report in Codecov by Sentry. |
…pport.ui Without this, `mypy` in strict mode gives: ``` Module "selenium.webdriver.support.ui" does not explicitly export attribute "Select" [attr-defined] ``` when following the documentation at https://selenium-python.readthedocs.io/navigating.html#filling-in-forms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Without this,
mypyin strict mode gives:when following the documentation at https://selenium-python.readthedocs.io/navigating.html#filling-in-forms.
Types of changes
Checklist