Fix loading from -hubConfig and -nodeConfig files - #2675
Merged
Conversation
Changes to make -hubConfg and -nodeConfig work again. * If/when a hub/node config file is passed, it is used to initialize the GridHubConfiguration or GridNodeConfiguration object in GridLauncherV3 * Any passed args (to GridLauncherV3) present from the command line will override values supplied in the hub/node config file. * Any value supplied for -hubConfig or -nodeConfig is checked for existence via new FileExistsValueValidator class Additional changes; * Hide parameter "-avoidProxy" from usage() * Remove whitespace in DefaultHub.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Xin the preceding checkbox, I verify that I have signed the Contributor License AgreementChanges to make -hubConfg and -nodeConfig work again.
the GridHubConfiguration or GridNodeConfiguration object in
GridLauncherV3
will override values supplied in the hub/node config file.
for existence via new FileExistsValueValidator class
Additional changes;