Fixes to FirefoxOptions.java - #3327
Merged
Merged
Conversation
- Remove unneeded check for both prefs and profile being present: According to mozilla/geckodriver#421 having both is valid. - Add getProfile method: Allows for use in intermediate nodes that need to modify the profile e.g. to add additional certs or extensions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unneeded check for both prefs and profile being present:
According to Can firefoxOptions contain both prefs and profile? mozilla/geckodriver#421
having both is valid.
Add getProfile method:
Allows for use in intermediate nodes that need to modify the profile
e.g. to add additional certs or extensions.
By placing an
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement