Add expected condition that waits for all found elements to be visible - #3532
Conversation
There was a problem hiding this comment.
I would write this as:
if _element_if_visible(element, visibility=False):
return False
instead of raising an exception.
There was a problem hiding this comment.
Thanks, @Dude-x, that makes sense! I've changed it locally. Can I merge it with this PR? If so, how?
There was a problem hiding this comment.
@BeyondEvil just push your changes to the same remote branch again... the PR will get updated automagically.
|
@BeyondEvil you should rebase before pushing so your PR doesn't contain unrelated commits |
542fd72 to
b450daa
Compare
|
@cgoldberg Yeah, I don't know what I'm doing lol ^^ But I got some help from the kind folks in IRC to fix it :) |
| from selenium.common.exceptions import StaleElementReferenceException | ||
| from selenium.common.exceptions import WebDriverException | ||
| from selenium.common.exceptions import NoAlertPresentException | ||
| from selenium.common.exceptions import ElementNotVisibleException |
There was a problem hiding this comment.
Is this an oversight for some code in the body?
There was a problem hiding this comment.
@Dude-x Yes, I'll remove that (it was used by the first revision of this PR).
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement