adding unit tests for 3.3,3.4,3.5 - #3638
Merged
Merged
Conversation
Contributor
Author
Contributor
|
Just a nit, but I'd position these between the Python 2.7 and 3.6 builds. Let's see the results in Travis before merging. |
Contributor
Author
|
Dave's comment made me identify a bug, I had duped 3.6 unit tests. commit #919b214 fixed it as well as moving the unit tests around |
Contributor
Author
|
@davehunt I'm gonna rely on you to parse the fails here. I think none of them matter, but want you to review if possible |
Contributor
|
@llaskin you need to include the new version numbers on lines 7 and 22, otherwise the command and deps are missing for those environments. |
davehunt
approved these changes
Mar 13, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement