Skip to content

Allow methods wrapped by EventFiringWebDriver and EventFiringWebElement to accept keyword arguments. - #806

Merged
lmtierney merged 1 commit into
SeleniumHQ:masterfrom
tbeadle:event_firing_webdriver_allow_kwargs
Apr 18, 2017
Merged

Allow methods wrapped by EventFiringWebDriver and EventFiringWebElement to accept keyword arguments.#806
lmtierney merged 1 commit into
SeleniumHQ:masterfrom
tbeadle:event_firing_webdriver_allow_kwargs

Conversation

@tbeadle

@tbeadle tbeadle commented Jul 17, 2015

Copy link
Copy Markdown
Contributor

@lukeis

lukeis commented Jul 21, 2015

Copy link
Copy Markdown
Member

@tbeadle can you descibe what was broken? and ideally add a scenario so it isn't broken in the future to the tests:

https://github.com/SeleniumHQ/selenium/blob/master/py/test/selenium/webdriver/common/correct_event_firing_tests.py

@barancev barancev added the C-py Python Bindings label Sep 3, 2015
@tbeadle
tbeadle force-pushed the event_firing_webdriver_allow_kwargs branch from a78e21d to 3039c42 Compare June 3, 2016 16:48
@tbeadle

tbeadle commented Jun 3, 2016

Copy link
Copy Markdown
Contributor Author

@lukeis This change is to make it so that, when an event listener is used, a caller can pass arguments by name and not just by position. I've added a unit test to demonstrate it. I confirmed that without my change, the test fails and with it, it passes. The Travis build failed for some reason, even though it shows that all the tests passed. I would appreciate any insight in to why that happened.

@isaulv

isaulv commented Mar 9, 2017

Copy link
Copy Markdown
Contributor

@tbeadle This seems like a nice useful fix. Can you please rebase your changes and also sign the CLA? If the CLA option doesn't appear, I think you should just create a new PR.

@tbeadle
tbeadle force-pushed the event_firing_webdriver_allow_kwargs branch from 3039c42 to 55d213b Compare March 12, 2017 13:50
@tbeadle
tbeadle force-pushed the event_firing_webdriver_allow_kwargs branch from 55d213b to c6db3fc Compare March 13, 2017 00:30
@lmtierney

Copy link
Copy Markdown
Member

@tbeadle I've updated your first comment to put the CLA checkbox back in, can you confirm you've signed the CLA and check the box?

@tbeadle

tbeadle commented Apr 18, 2017

Copy link
Copy Markdown
Contributor Author

@lmtierney I've signed the CLA and updated the comment to select the checkbox.

@lmtierney

Copy link
Copy Markdown
Member

thanks @tbeadle

@lmtierney
lmtierney merged commit 0c6f254 into SeleniumHQ:master Apr 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-py Python Bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants