Allow methods wrapped by EventFiringWebDriver and EventFiringWebElement to accept keyword arguments. - #806
Conversation
|
@tbeadle can you descibe what was broken? and ideally add a scenario so it isn't broken in the future to the tests: |
a78e21d to
3039c42
Compare
|
@lukeis This change is to make it so that, when an event listener is used, a caller can pass arguments by name and not just by position. I've added a unit test to demonstrate it. I confirmed that without my change, the test fails and with it, it passes. The Travis build failed for some reason, even though it shows that all the tests passed. I would appreciate any insight in to why that happened. |
|
@tbeadle This seems like a nice useful fix. Can you please rebase your changes and also sign the CLA? If the CLA option doesn't appear, I think you should just create a new PR. |
3039c42 to
55d213b
Compare
to accept keyword arguments
55d213b to
c6db3fc
Compare
|
@tbeadle I've updated your first comment to put the CLA checkbox back in, can you confirm you've signed the CLA and check the box? |
|
@lmtierney I've signed the CLA and updated the comment to select the checkbox. |
|
thanks @tbeadle |
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement