Add registration secret as header in node responses - #8661
Merged
Conversation
Member
Author
|
@adamgoucher Do you mind taking a look at my start for fixing #8559 ? I am trying to find the places where the header will be validated. If possible, please point some files here, where the header should be validated :) |
raju249
marked this pull request as ready for review
September 3, 2020 09:52
Member
|
There are linting errors, please fix those |
raju249
force-pushed
the
registration-secret
branch
2 times, most recently
from
September 7, 2020 09:40
bb90fff to
6b91b4d
Compare
Member
Author
|
@adamgoucher Do you mind reviewing/approving this PR? 🙇 |
Contributor
|
My theory for how to test this is
The theory is that the hub would send a message and the node would reply without the header present and the hub would no longer trust the node and pull it out of the pool, not send commands, etc. |
raju249
force-pushed
the
registration-secret
branch
from
September 24, 2020 09:57
974e194 to
6389a52
Compare
Member
Author
|
I have fixed the conflicts. |
AutomatedTester
approved these changes
Sep 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Fixes #8559
Motivation and Context
Types of changes
Checklist