fix: do not update already set preference - #8692
Merged
AutomatedTester merged 2 commits intoSep 15, 2020
Merged
Conversation
Inside the python binding we are reading from an already defined js file for the frozen config and if user is trying to set those particular keys in firefox profile, the changes aren't getting reflected. This leads to a very inconsistent behavior on the user end. We should not update the default preferences in the object if it is already defined by the user using `set_preferences` and should do a key check before storing it in the dict.
AutomatedTester
approved these changes
Sep 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Inside the python binding we are reading from an already defined js file
for the frozen config and if user is trying to set those particular keys
in firefox profile, the changes aren't getting reflected. This leads to
a very inconsistent behavior on the user end.
We should not update the default preferences in the object if it is
already defined by the user using
set_preferencesand should do a keycheck before storing it in the dict.
Motivation and Context
I was testing a javascript function behavior of
window.openand wanted to open it in a new tab insteadof a window, and trying to set the config through firefox profile options but it was not being picked later
when did a little digging into the client binding code founded that we are overriding the values with some
set of frozen keys. Had to make those changes for it to work. So thought it might be beneficial for the
community as well.
Types of changes
Checklist