Skip to content

Fix OpenTelemetry wrapper for the version 0.9.1 upgrade. - #8835

Merged
diemol merged 2 commits into
SeleniumHQ:trunkfrom
pujagani:opentelemetry_0.9.1_fix
Nov 4, 2020
Merged

Fix OpenTelemetry wrapper for the version 0.9.1 upgrade.#8835
diemol merged 2 commits into
SeleniumHQ:trunkfrom
pujagani:opentelemetry_0.9.1_fix

Conversation

@pujagani

@pujagani pujagani commented Nov 3, 2020

Copy link
Copy Markdown
Contributor

Description

Fix OpenTelemetry wrapper to accomodate 0.9.1 version bump.

Motivation and Context

Version bump for OpenTelemetry to 0.9.1 had many breaking changes as listed in :
https://github.com/open-telemetry/opentelemetry-java/blob/master/CHANGELOG.md

  • The changes made update OpenTelemetry wrapper APIs for trace id and span id.
  • Status is no longer supported. Hence, updated the wrapper to use StatusCanonicalCode.
  • Updated LoggingOptions to use Attributes for events and AttributesConsumer for correct json mapping for events and attributes.
  • Updating LoggingOptions to use OpenTelemetrySdk.getTracerManagement() to while getting a provider, since the current version returns an interface instead of provider implementation.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pujagani
pujagani force-pushed the opentelemetry_0.9.1_fix branch from 2db4373 to 828d2af Compare November 3, 2020 16:13

@diemol diemol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @pujagani!

@diemol
diemol merged commit c8f03a4 into SeleniumHQ:trunk Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants