Add implementation for context propagation based on changed in OpenTelemetry 0.9.0. - #8884
Merged
AutomatedTester merged 4 commits intoNov 19, 2020
Conversation
pujagani
force-pushed
the
opentelemetry_context_propagation
branch
from
November 18, 2020 11:25
e38d58e to
8a3e6af
Compare
AutomatedTester
approved these changes
Nov 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
The changes add the required implementation for a propagating the tracing context correctly.
Motivation and Context
The version bump to 0.9.0 for OpenTelemertry made a breaking change of returning no-op TextMapPropagator. As a result, the trace context was not being passed when "inject" operation was called. So in a full distributed grid mode, a request had a different trace id and context as it made its way through different Grid 4 components instead of the same trace id. Thus, defeating the purpose of tracing.
The changes fix the above-mentioned issue by passing a valid implementation of TextMapPropagator. The changes add a unit test to safe-guard from future breaking changes in OpenTelemetry.
Types of changes
Checklist