Skip to content

chore: Use subfolder for NPM package homepage - #8938

Merged
diemol merged 2 commits into
SeleniumHQ:trunkfrom
nschonni:patch-1
Dec 18, 2020
Merged

chore: Use subfolder for NPM package homepage#8938
diemol merged 2 commits into
SeleniumHQ:trunkfrom
nschonni:patch-1

Conversation

@nschonni

@nschonni nschonni commented Dec 8, 2020

Copy link
Copy Markdown
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Changes the NPM package homepage to the folder where the package contents are located

Motivation and Context

When trying to trace back something in the NPM package so I could look at the source it was initially not super clear where to find the source for this package in the larger repo

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant

CLAassistant commented Dec 8, 2020

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@nschonni

Copy link
Copy Markdown
Contributor Author

@diemol this is another small quality of life fix, but I'm fine if it's closed

@harsha509 harsha509 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nschonni !

@diemol diemol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @nschonni!

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@diemol
diemol merged commit 2cc9ea2 into SeleniumHQ:trunk Dec 18, 2020
@nschonni
nschonni deleted the patch-1 branch December 18, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants