Skip to content

[grid] Make distributor pick up session requests from the queue only if the grid is not full - #8940

Merged
diemol merged 9 commits into
SeleniumHQ:trunkfrom
pujagani:newsession-distributor-handling
Dec 21, 2020
Merged

[grid] Make distributor pick up session requests from the queue only if the grid is not full#8940
diemol merged 9 commits into
SeleniumHQ:trunkfrom
pujagani:newsession-distributor-handling

Conversation

@pujagani

@pujagani pujagani commented Dec 9, 2020

Copy link
Copy Markdown
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Add a feature to pick up new session requests from the new session queue only if the grid is not busy.

Motivation and Context

Currently, the Distributor will pick up requests from the queue immediately as soon as they arrive and if the Grid is busy then it will initiate a retry. Ideally, the Distributor should check if there are any new requests and if the Grid can handle the new request and accordingly poll the new session queue. New session queue is actually a staging area for the new requests. The changes address this.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pujagani
pujagani force-pushed the newsession-distributor-handling branch from c1d3cfe to f09c984 Compare December 9, 2020 06:57
@sonarqubecloud

Copy link
Copy Markdown

@diemol
diemol merged commit a522fb7 into SeleniumHQ:trunk Dec 21, 2020
@pujagani

Copy link
Copy Markdown
Contributor Author

Thank you Diego! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants