[grid] Make distributor pick up session requests from the queue only if the grid is not full - #8940
Merged
diemol merged 9 commits intoDec 21, 2020
Conversation
…if the grid is not full
pujagani
force-pushed
the
newsession-distributor-handling
branch
from
December 9, 2020 06:57
c1d3cfe to
f09c984
Compare
|
SonarCloud Quality Gate failed. |
diemol
approved these changes
Dec 21, 2020
Contributor
Author
|
Thank you Diego! :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Add a feature to pick up new session requests from the new session queue only if the grid is not busy.
Motivation and Context
Currently, the Distributor will pick up requests from the queue immediately as soon as they arrive and if the Grid is busy then it will initiate a retry. Ideally, the Distributor should check if there are any new requests and if the Grid can handle the new request and accordingly poll the new session queue. New session queue is actually a staging area for the new requests. The changes address this.
Types of changes
Checklist