Skip to content

[node] Fix typo: tracingCategories -> traceCategories - #8976

Merged
diemol merged 1 commit into
SeleniumHQ:trunkfrom
andrewiggins:patch-1
Dec 17, 2020
Merged

[node] Fix typo: tracingCategories -> traceCategories#8976
diemol merged 1 commit into
SeleniumHQ:trunkfrom
andrewiggins:patch-1

Conversation

@andrewiggins

Copy link
Copy Markdown
Contributor

Description

Fix a typo in the documentation for setPerfLoggingPrefs of the chromium.Options class

Motivation and context

According the ChromeDriver docs this field is called traceCategories not tracingCategories. Further I'm getting the following error when trying to use tracingCategories. Using traceCategories fixes it.

This is using ChromeDriver 87.0.4280.20 (c99e81631faa0b2a448e658c0dbd8311fb04ddbd-refs/branch-heads/4280@{#355}) on Windows.

InvalidArgumentError: invalid argument: cannot parse capability: goog:chromeOptions
from invalid argument: cannot parse perfLoggingPrefs
from invalid argument: unrecognized performance logging option: tracingCategories
    at Object.throwDecodedError (D:\github\andrewiggins\tachometer\node_modules\selenium-webdriver\lib\error.js:517:15)
    at parseHttpResponse (D:\github\andrewiggins\tachometer\node_modules\selenium-webdriver\lib\http.js:655:13)
    at Executor.execute (D:\github\andrewiggins\tachometer\node_modules\selenium-webdriver\lib\http.js:581:28)
    at processTicksAndRejections (node:internal/process/task_queues:93:5) {
  remoteStacktrace: 'Backtrace:\n' +
    '\tOrdinal0 [0x007DECE3+3337443]\n' +
    '\tOrdinal0 [0x006BF041+2158657]\n' +
    '\tOrdinal0 [0x00546FA8+618408]\n' +
    '\tOrdinal0 [0x004B83DA+33754]\n' +
    '\tOrdinal0 [0x004BAB74+43892]\n' +
    '\tOrdinal0 [0x004B72A3+29347]\n' +
    '\tOrdinal0 [0x004BAB74+43892]\n' +
    '\tOrdinal0 [0x004B515D+20829]\n' +
    '\tOrdinal0 [0x004E4F6C+216940]\n' +
    '\tOrdinal0 [0x004E4C2E+216110]\n' +
    '\tOrdinal0 [0x004E5D4B+220491]\n' +
    '\tOrdinal0 [0x004E5BFC+220156]\n' +
    '\tOrdinal0 [0x004E181B+202779]\n' +
    '\tOrdinal0 [0x004C3D74+81268]\n' +
    '\tOrdinal0 [0x004C4D6E+85358]\n' +
    '\tOrdinal0 [0x004C4CF9+85241]\n' +
    '\tOrdinal0 [0x006D6F2C+2256684]\n' +
    '\tGetHandleVerifier [0x00962FAC+1478332]\n' +
    '\tGetHandleVerifier [0x00962AFD+1477133]\n' +
    '\tGetHandleVerifier [0x0096AAD8+1509864]\n' +
    '\tGetHandleVerifier [0x0096369E+1480110]\n' +
    '\tOrdinal0 [0x006CD6BD+2217661]\n' +
    '\tOrdinal0 [0x006D89AB+2263467]\n' +
    '\tOrdinal0 [0x006D8AEF+2263791]\n' +
    '\tOrdinal0 [0x006ED363+2347875]\n' +
    '\tBaseThreadInitThunk [0x76D3FA29+25]\n' +
    '\tRtlGetAppContainerNamedObjectPath [0x772B75F4+228]\n' +
    '\tRtlGetAppContainerNamedObjectPath [0x772B75C4+180]\n'
}

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

According the [ChromeDriver docs](https://chromedriver.chromium.org/capabilities#TOC-perfLoggingPrefs-object) this field is called `traceCategories` not `tracingCategories`. Further I'm getting the following error when trying to use `tracingCategories`. Using `traceCategories` fixes it.

This is using ChromeDriver 87.0.4280.20 (c99e81631faa0b2a448e658c0dbd8311fb04ddbd-refs/branch-heads/4280@{SeleniumHQ#355}) on Windows.

```
InvalidArgumentError: invalid argument: cannot parse capability: goog:chromeOptions
from invalid argument: cannot parse perfLoggingPrefs
from invalid argument: unrecognized performance logging option: tracingCategories
    at Object.throwDecodedError (D:\github\andrewiggins\tachometer\node_modules\selenium-webdriver\lib\error.js:517:15)
    at parseHttpResponse (D:\github\andrewiggins\tachometer\node_modules\selenium-webdriver\lib\http.js:655:13)
    at Executor.execute (D:\github\andrewiggins\tachometer\node_modules\selenium-webdriver\lib\http.js:581:28)
    at processTicksAndRejections (node:internal/process/task_queues:93:5) {
  remoteStacktrace: 'Backtrace:\n' +
    '\tOrdinal0 [0x007DECE3+3337443]\n' +
    '\tOrdinal0 [0x006BF041+2158657]\n' +
    '\tOrdinal0 [0x00546FA8+618408]\n' +
    '\tOrdinal0 [0x004B83DA+33754]\n' +
    '\tOrdinal0 [0x004BAB74+43892]\n' +
    '\tOrdinal0 [0x004B72A3+29347]\n' +
    '\tOrdinal0 [0x004BAB74+43892]\n' +
    '\tOrdinal0 [0x004B515D+20829]\n' +
    '\tOrdinal0 [0x004E4F6C+216940]\n' +
    '\tOrdinal0 [0x004E4C2E+216110]\n' +
    '\tOrdinal0 [0x004E5D4B+220491]\n' +
    '\tOrdinal0 [0x004E5BFC+220156]\n' +
    '\tOrdinal0 [0x004E181B+202779]\n' +
    '\tOrdinal0 [0x004C3D74+81268]\n' +
    '\tOrdinal0 [0x004C4D6E+85358]\n' +
    '\tOrdinal0 [0x004C4CF9+85241]\n' +
    '\tOrdinal0 [0x006D6F2C+2256684]\n' +
    '\tGetHandleVerifier [0x00962FAC+1478332]\n' +
    '\tGetHandleVerifier [0x00962AFD+1477133]\n' +
    '\tGetHandleVerifier [0x0096AAD8+1509864]\n' +
    '\tGetHandleVerifier [0x0096369E+1480110]\n' +
    '\tOrdinal0 [0x006CD6BD+2217661]\n' +
    '\tOrdinal0 [0x006D89AB+2263467]\n' +
    '\tOrdinal0 [0x006D8AEF+2263791]\n' +
    '\tOrdinal0 [0x006ED363+2347875]\n' +
    '\tBaseThreadInitThunk [0x76D3FA29+25]\n' +
    '\tRtlGetAppContainerNamedObjectPath [0x772B75F4+228]\n' +
    '\tRtlGetAppContainerNamedObjectPath [0x772B75C4+180]\n'
}
```
@CLAassistant

CLAassistant commented Dec 17, 2020

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@diemol diemol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @andrewiggins!

@diemol
diemol merged commit f86f6f9 into SeleniumHQ:trunk Dec 17, 2020
@andrewiggins
andrewiggins deleted the patch-1 branch December 17, 2020 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants