Skip to content

Add attribute_to_be_include method to expected_conditions when the at… - #9200

Merged
AutomatedTester merged 12 commits into
SeleniumHQ:trunkfrom
sunnyyukaige:my-feature-branch
Mar 2, 2021
Merged

Add attribute_to_be_include method to expected_conditions when the at…#9200
AutomatedTester merged 12 commits into
SeleniumHQ:trunkfrom
sunnyyukaige:my-feature-branch

Conversation

@sunnyyukaige

@sunnyyukaige sunnyyukaige commented Feb 22, 2021

Copy link
Copy Markdown
Contributor

…tribute given is include the element's attributes

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Add attribute_to_be_include method to expected_conditions when the attribute given is include the element's attributes

Motivation and Context

Can use attribute_to_be_include method of expected_conditions when the attribute given is include the element's attributes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sunnyyukaige

Copy link
Copy Markdown
Contributor Author

@AutomatedTester the test relative of my change all pass, look forward for your review, many many thx 😋

Comment thread py/selenium/webdriver/support/expected_conditions.py Outdated
@AutomatedTester
AutomatedTester merged commit a65ff1c into SeleniumHQ:trunk Mar 2, 2021
@sonarqubecloud

sonarqubecloud Bot commented Mar 2, 2021

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants