Skip to content

[grid] Using a single Netty client instance - #9227

Merged
diemol merged 4 commits into
trunkfrom
http-client0-single-instance
Mar 2, 2021
Merged

[grid] Using a single Netty client instance#9227
diemol merged 4 commits into
trunkfrom
http-client0-single-instance

Conversation

@diemol

@diemol diemol commented Mar 1, 2021

Copy link
Copy Markdown
Member

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

This helps to reduce the amount of thread pools
used to handle connections. This change is
possibleTimeouts because timeouts can be set
per request.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

diemol added 2 commits March 1, 2021 21:34
This helps to reduce the amount of thread pools
used to handle connections. This change is
possibleTimeouts because timeouts can be set
per request.
NettyMessages.toNettyRequest(
getConfig().baseUri(),
toClampedInt(getConfig().readTimeout().toMillis()),
toClampedInt(getConfig().readTimeout().toMillis()),

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One down side of this is that we cannot add a connectionTimeout per request. Currently the default is 10s, we could leave a high value (60s?) to fit most use cases.
What do you think, @shs96c @barancev?

@sonarqubecloud

sonarqubecloud Bot commented Mar 2, 2021

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant