Skip to content

Update example in edge.js - #9231

Merged
harsha509 merged 2 commits into
SeleniumHQ:trunkfrom
hectorhon:patch-1
Mar 2, 2021
Merged

Update example in edge.js#9231
harsha509 merged 2 commits into
SeleniumHQ:trunkfrom
hectorhon:patch-1

Conversation

@hectorhon

Copy link
Copy Markdown
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Update example in edge.js
In particular, change options.useEdgeChromium(true) to options.setEdgeChromium(true).

Motivation and Context

Fix outdated documentation in edge.js file header.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

In particular, change options.useEdgeChromium(true) to options.setEdgeChromium(true).
@CLAassistant

CLAassistant commented Mar 2, 2021

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@sonarqubecloud

sonarqubecloud Bot commented Mar 2, 2021

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@harsha509
harsha509 merged commit bd468dd into SeleniumHQ:trunk Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants