Skip to content

[grid] Fix build due to SessionRequests renaming - #9397

Merged
shs96c merged 1 commit into
SeleniumHQ:trunkfrom
pujagani:fix-newsessionqueue-tests
Apr 20, 2021
Merged

[grid] Fix build due to SessionRequests renaming#9397
shs96c merged 1 commit into
SeleniumHQ:trunkfrom
pujagani:fix-newsessionqueue-tests

Conversation

@pujagani

@pujagani pujagani commented Apr 20, 2021

Copy link
Copy Markdown
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Fix build due to SessionRequests renaming

Motivation and Context

The java build was breaking due since it was unable to find LocalSessionRequests. The LocalSessionRequests class contents were merged into SessionRequests class. The changes rename the LocalSessionRequests to SessionRequests all necessary source files and test files.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sonarqubecloud

Copy link
Copy Markdown

@shs96c shs96c left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic. Thank you for fixing this!

@shs96c
shs96c merged commit 1d31428 into SeleniumHQ:trunk Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants