Meshlet based culling#1089
Merged
Merged
Conversation
xPaw
reviewed
Feb 11, 2026
| AggregateDrawBounds = 14, | ||
| MeshletInfo = 15, | ||
|
|
||
| // do not exceed 16 |
Member
There was a problem hiding this comment.
better explanation comment. also why did it jump from 3 to 8 anyway?
xPaw
reviewed
Feb 11, 2026
| public readonly struct Frustum | ||
| { | ||
| private Vector4[] Planes = new Vector4[6]; | ||
| [MarshalAs(UnmanagedType.ByValArray, SizeConst = 6)] |
Member
Author
There was a problem hiding this comment.
Fixed by making empty frustum have 6 planes as well
xPaw
reviewed
Feb 11, 2026
| [StructLayout(LayoutKind.Sequential)] | ||
| public struct PackedAABB | ||
| { | ||
| //HACK HACK HACK |
xPaw
reviewed
Feb 11, 2026
|
|
||
| var m_CullingData = new MeshletInfo.CullingData() | ||
| { | ||
| m_ConeAxis0 = (sbyte)meshletCall.GetSubCollection("m_CullingData").GetIntegerArray("m_ConeAxis")[0], |
Member
There was a problem hiding this comment.
GetSubCollection (above), GetIntegerArray once
xPaw
reviewed
Feb 11, 2026
| m_nParentBoundIndex = (uint)i + (uint)preDrawBoundsCount | ||
| }; | ||
| if (isAggregate) | ||
| { |
Member
There was a problem hiding this comment.
why is this loop even running for non-isAggregate
xPaw
reviewed
Feb 11, 2026
| public List<Entity> Entities { get; } = []; | ||
| public WorldNode? MainWorldNode { get; private set; } | ||
|
|
||
| public HashSet<string> DefaultEnabledLayers { get; } = ["Entities", "Particles"]; |
kristiker
commented
Feb 11, 2026
kristiker
commented
Feb 11, 2026
1d01b30 to
5a243e7
Compare
This reverts commit e7093a6.
…irect render when draw count is low or drawing outline.
8d4e053 to
1866058
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lowers CPU usage.
Todo: