Skip to content

Commit 3374fdf

Browse files
authored
Deprecate delegate_to param in GCP operators and update docs (#29088)
* deprecate "delegate_to" parameter in all gcloud hooks & operators * update google cloud connection docs regarding domain-wide delegation
1 parent efaed34 commit 3374fdf

101 files changed

Lines changed: 1003 additions & 3 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

airflow/providers/apache/beam/operators/beam.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
import os
2323
import stat
2424
import tempfile
25+
import warnings
2526
from abc import ABC, ABCMeta, abstractmethod
2627
from concurrent.futures import ThreadPoolExecutor, as_completed
2728
from contextlib import ExitStack
@@ -169,6 +170,10 @@ def __init__(
169170
self.default_pipeline_options = default_pipeline_options or {}
170171
self.pipeline_options = pipeline_options or {}
171172
self.gcp_conn_id = gcp_conn_id
173+
if delegate_to:
174+
warnings.warn(
175+
"'delegate_to' parameter is deprecated, please use 'impersonation_chain'", DeprecationWarning
176+
)
172177
self.delegate_to = delegate_to
173178
if isinstance(dataflow_config, dict):
174179
self.dataflow_config = DataflowConfiguration(**dataflow_config)

airflow/providers/google/cloud/hooks/automl.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
"""
2525
from __future__ import annotations
2626

27+
import warnings
2728
from typing import Sequence
2829

2930
from google.api_core.gapic_v1.method import DEFAULT, _MethodDefault
@@ -67,6 +68,10 @@ def __init__(
6768
delegate_to: str | None = None,
6869
impersonation_chain: str | Sequence[str] | None = None,
6970
) -> None:
71+
if delegate_to:
72+
warnings.warn(
73+
"'delegate_to' parameter is deprecated, please use 'impersonation_chain'", DeprecationWarning
74+
)
7075
super().__init__(
7176
gcp_conn_id=gcp_conn_id,
7277
delegate_to=delegate_to,

airflow/providers/google/cloud/hooks/bigquery.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,10 @@ def __init__(
9797
impersonation_chain: str | Sequence[str] | None = None,
9898
labels: dict | None = None,
9999
) -> None:
100+
if delegate_to:
101+
warnings.warn(
102+
"'delegate_to' parameter is deprecated, please use 'impersonation_chain'", DeprecationWarning
103+
)
100104
super().__init__(
101105
gcp_conn_id=gcp_conn_id,
102106
delegate_to=delegate_to,

airflow/providers/google/cloud/hooks/bigquery_dts.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
"""This module contains a BigQuery Hook."""
1919
from __future__ import annotations
2020

21+
import warnings
2122
from copy import copy
2223
from typing import Sequence
2324

@@ -61,6 +62,10 @@ def __init__(
6162
location: str | None = None,
6263
impersonation_chain: str | Sequence[str] | None = None,
6364
) -> None:
65+
if delegate_to:
66+
warnings.warn(
67+
"'delegate_to' parameter is deprecated, please use 'impersonation_chain'", DeprecationWarning
68+
)
6469
super().__init__(
6570
gcp_conn_id=gcp_conn_id,
6671
delegate_to=delegate_to,

airflow/providers/google/cloud/hooks/bigtable.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
from __future__ import annotations
2020

2121
import enum
22+
import warnings
2223
from typing import Sequence
2324

2425
from google.cloud.bigtable import Client
@@ -46,6 +47,10 @@ def __init__(
4647
delegate_to: str | None = None,
4748
impersonation_chain: str | Sequence[str] | None = None,
4849
) -> None:
50+
if delegate_to:
51+
warnings.warn(
52+
"'delegate_to' parameter is deprecated, please use 'impersonation_chain'", DeprecationWarning
53+
)
4954
super().__init__(
5055
gcp_conn_id=gcp_conn_id,
5156
delegate_to=delegate_to,

airflow/providers/google/cloud/hooks/cloud_build.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
"""Hook for Google Cloud Build service."""
1919
from __future__ import annotations
2020

21+
import warnings
2122
from typing import Sequence
2223

2324
from google.api_core.exceptions import AlreadyExists
@@ -59,6 +60,10 @@ def __init__(
5960
delegate_to: str | None = None,
6061
impersonation_chain: str | Sequence[str] | None = None,
6162
) -> None:
63+
if delegate_to:
64+
warnings.warn(
65+
"'delegate_to' parameter is deprecated, please use 'impersonation_chain'", DeprecationWarning
66+
)
6267
super().__init__(
6368
gcp_conn_id=gcp_conn_id, delegate_to=delegate_to, impersonation_chain=impersonation_chain
6469
)

airflow/providers/google/cloud/hooks/cloud_memorystore.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
"""
2828
from __future__ import annotations
2929

30+
import warnings
3031
from typing import Sequence
3132

3233
from google.api_core import path_template
@@ -76,6 +77,10 @@ def __init__(
7677
delegate_to: str | None = None,
7778
impersonation_chain: str | Sequence[str] | None = None,
7879
) -> None:
80+
if delegate_to:
81+
warnings.warn(
82+
"'delegate_to' parameter is deprecated, please use 'impersonation_chain'", DeprecationWarning
83+
)
7984
super().__init__(
8085
gcp_conn_id=gcp_conn_id,
8186
delegate_to=delegate_to,

airflow/providers/google/cloud/hooks/cloud_sql.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
import subprocess
3232
import time
3333
import uuid
34+
import warnings
3435
from inspect import signature
3536
from pathlib import Path
3637
from subprocess import PIPE, Popen
@@ -94,6 +95,10 @@ def __init__(
9495
delegate_to: str | None = None,
9596
impersonation_chain: str | Sequence[str] | None = None,
9697
) -> None:
98+
if delegate_to:
99+
warnings.warn(
100+
"'delegate_to' parameter is deprecated, please use 'impersonation_chain'", DeprecationWarning
101+
)
97102
super().__init__(
98103
gcp_conn_id=gcp_conn_id,
99104
delegate_to=delegate_to,

airflow/providers/google/cloud/hooks/cloud_storage_transfer_service.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,10 @@ def __init__(
130130
delegate_to: str | None = None,
131131
impersonation_chain: str | Sequence[str] | None = None,
132132
) -> None:
133+
if delegate_to:
134+
warnings.warn(
135+
"'delegate_to' parameter is deprecated, please use 'impersonation_chain'", DeprecationWarning
136+
)
133137
super().__init__(
134138
gcp_conn_id=gcp_conn_id,
135139
delegate_to=delegate_to,

airflow/providers/google/cloud/hooks/compute.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
from __future__ import annotations
2020

2121
import time
22+
import warnings
2223
from typing import Any, Sequence
2324

2425
from google.api_core.retry import Retry
@@ -58,6 +59,10 @@ def __init__(
5859
delegate_to: str | None = None,
5960
impersonation_chain: str | Sequence[str] | None = None,
6061
) -> None:
62+
if delegate_to:
63+
warnings.warn(
64+
"'delegate_to' parameter is deprecated, please use 'impersonation_chain'", DeprecationWarning
65+
)
6166
super().__init__(
6267
gcp_conn_id=gcp_conn_id,
6368
delegate_to=delegate_to,

0 commit comments

Comments
 (0)