Skip to content

Commit 6b3bb3c

Browse files
author
Łukasz Wyszomirski
authored
Change log level to DEBUG when secret not found for google secret manager (#27856)
1 parent 144f88b commit 6b3bb3c

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

airflow/providers/google/cloud/_internal_client/secret_manager_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ def get_secret(self, secret_id: str, project_id: str, secret_version: str = "lat
7575
value = response.payload.data.decode("UTF-8")
7676
return value
7777
except NotFound:
78-
self.log.error("Google Cloud API Call Error (NotFound): Secret ID %s not found.", secret_id)
78+
self.log.debug("Google Cloud API Call Error (NotFound): Secret ID %s not found.", secret_id)
7979
return None
8080
except PermissionDenied:
8181
self.log.error(

tests/providers/google/cloud/secrets/test_secret_manager.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ def test_get_conn_uri_non_existent_key(self, mock_client_callable, mock_get_cred
127127

128128
secrets_manager_backend = CloudSecretManagerBackend(connections_prefix=CONNECTIONS_PREFIX)
129129
secret_id = secrets_manager_backend.build_path(CONNECTIONS_PREFIX, CONN_ID, SEP)
130-
with self.assertLogs(secrets_manager_backend.client.log, level="ERROR") as log_output:
130+
with self.assertLogs(secrets_manager_backend.client.log, level="DEBUG") as log_output:
131131
assert secrets_manager_backend.get_conn_uri(conn_id=CONN_ID) is None
132132
assert secrets_manager_backend.get_connection(conn_id=CONN_ID) is None
133133
assert re.search(
@@ -202,7 +202,7 @@ def test_get_variable_non_existent_key(self, mock_client_callable, mock_get_cred
202202

203203
secrets_manager_backend = CloudSecretManagerBackend(variables_prefix=VARIABLES_PREFIX)
204204
secret_id = secrets_manager_backend.build_path(VARIABLES_PREFIX, VAR_KEY, SEP)
205-
with self.assertLogs(secrets_manager_backend.client.log, level="ERROR") as log_output:
205+
with self.assertLogs(secrets_manager_backend.client.log, level="DEBUG") as log_output:
206206
assert secrets_manager_backend.get_variable(VAR_KEY) is None
207207
assert re.search(
208208
f"Google Cloud API Call Error \\(NotFound\\): Secret ID {secret_id} not found",

0 commit comments

Comments
 (0)