Fix the gcp_gcs_delete_objects on empty list (#32383)

yupbank · web-flow · commit e7587b3369af · 2023-07-06T11:47:59.000+02:00
diff --git a/airflow/providers/google/cloud/operators/gcs.py b/airflow/providers/google/cloud/operators/gcs.py
@@ -323,7 +323,7 @@ def execute(self, context: Context) -> None:
             impersonation_chain=self.impersonation_chain,
         )
 
-        if self.objects:
+        if self.objects is not None:
             objects = self.objects
         else:
             objects = hook.list(bucket_name=self.bucket_name, prefix=self.prefix)
diff --git a/tests/providers/google/cloud/operators/test_gcs.py b/tests/providers/google/cloud/operators/test_gcs.py
@@ -124,6 +124,14 @@ def test_delete_objects(self, mock_hook):
             any_order=True,
         )
 
+    @mock.patch("airflow.providers.google.cloud.operators.gcs.GCSHook")
+    def test_delete_empty_list_of_objects(self, mock_hook):
+        operator = GCSDeleteObjectsOperator(task_id=TASK_ID, bucket_name=TEST_BUCKET, objects=[])
+
+        operator.execute(None)
+        mock_hook.return_value.list.assert_not_called()
+        mock_hook.return_value.delete.assert_not_called()
+
     @mock.patch("airflow.providers.google.cloud.operators.gcs.GCSHook")
     def test_delete_prefix(self, mock_hook):
         mock_hook.return_value.list.return_value = MOCK_FILES[1:4]

Original file line number	Diff line number	Diff line change
`@@ -323,7 +323,7 @@ def execute(self, context: Context) -> None:`
`323`	`323`	`impersonation_chain=self.impersonation_chain,`
`324`	`324`	`)`
`325`	`325`
`326`		`- if self.objects:`
	`326`	`+ if self.objects is not None:`
`327`	`327`	`objects = self.objects`
`328`	`328`	`else:`
`329`	`329`	`objects = hook.list(bucket_name=self.bucket_name, prefix=self.prefix)`