This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-860] Update to modern nullptr usage#12352
Merged
marcoabreu merged 2 commits intoapache:masterfrom Sep 20, 2018
Merged
Conversation
1c138b3 to
7925409
Compare
7925409 to
340d5c9
Compare
Contributor
Author
|
@mxnet-label-bot can please add [pr-awaiting-review] |
a7ca93a to
3777f33
Compare
3777f33 to
4e34eec
Compare
lebeg
approved these changes
Sep 17, 2018
marcoabreu
approved these changes
Sep 18, 2018
Contributor
|
Please resolve the conflict |
4e34eec to
c6b7594
Compare
Contributor
Author
|
@marcoabreu Rebased and ready to go. |
Contributor
|
Another conflict :/ |
c6b7594 to
c9c9907
Compare
c9c9907 to
768d519
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes a few NULL assignments to the more specific C++11 nullptr.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.