This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Merged
Conversation
332afa9 to
9bf127d
Compare
9bf127d to
2faebb3
Compare
4774a0f to
9984940
Compare
9984940 to
0bd501d
Compare
26763c7 to
8d84fff
Compare
szha
reviewed
Sep 24, 2018
| ifeq ($(ENABLE_TESTCOVERAGE), 1) | ||
| CFLAGS += --coverage | ||
| LDFLAGS += --coverage | ||
| endif |
Member
There was a problem hiding this comment.
need to make sure this flag is portable to other compilers/linkers. I checked for gcc and clang, both of which supports gcov.
https://gcc.gnu.org/onlinedocs/gcc/Instrumentation-Options.html#Instrumentation-Options
https://clang.llvm.org/docs/SourceBasedCodeCoverage.html
Contributor
Author
There was a problem hiding this comment.
It's only compatible with GCC and clang, right. Want me to add a check?
Contributor
Author
|
Here's an example report: https://codecov.io/gh/apache/incubator-mxnet/tree/26763c7b686f6059beabf7e56dd98bf1e526ab52 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds coverage metrics for the C++ backend.
Something to verify at a later stage: Compare coverage result of optimized builds with non-optimized: https://github.com/pyarmak/cmake-gtest-coverage-example/blob/master/cmake/modules/CodeCoverage.cmake