This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Use omp threads for cpu data loader#15379
Merged
anirudh2290 merged 3 commits intoapache:masterfrom Jul 2, 2019
Merged
Conversation
Member
|
@mxnet-label-bot add [pr-awaiting-review] |
anirudh2290
reviewed
Jul 2, 2019
| { | ||
| threadget = omp_get_num_threads(); | ||
| if (prefetch_param.ctx == PrefetcherParam::CtxType::kCPU) { | ||
| threadget = engine::OpenMP::Get()->GetRecommendedOMPThreadCount(); |
Member
There was a problem hiding this comment.
Since prefetching is happening in parallel with op execution. won't this cause too many threads to be launched when we are also useing openmp threads to execute operators.
Contributor
Author
There was a problem hiding this comment.
No. For CPU optimized data loader, prefetching isn't happened.
Prefetching will flush cache, causing CPU op execution much slower. So for CPU optimized data loader, the loader itself works as a normal operator, which will be executed exclusively, utilizing all omp threads.
Member
There was a problem hiding this comment.
ohh okay, I didnt realize that the code paths are different for CPU and GPU iterators now. LGTM :)
anirudh2290
approved these changes
Jul 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CPU data loader works as a normal op, so it's naturally to use omp threads number. This change can help to improve data loader performance for non-core-binding usage.
@pengzhao-intel @anirudh2290
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments