This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[MKLDNN]Support fullyconnected and element-wise ops fusion#15950
Merged
pengzhao-intel merged 5 commits intoapache:masterfrom Aug 22, 2019
Merged
[MKLDNN]Support fullyconnected and element-wise ops fusion#15950pengzhao-intel merged 5 commits intoapache:masterfrom
pengzhao-intel merged 5 commits intoapache:masterfrom
Conversation
ZhennanQin
reviewed
Aug 20, 2019
| } | ||
| if (new_node.op() == Op::Get("clip")) { | ||
| const ClipParam ¶m = nnvm::get<ClipParam>(new_node.attrs.parsed); | ||
| if (param.a_min == 0.f && param.a_max == 1.0f) { |
Contributor
There was a problem hiding this comment.
why a_max have to be 1.0f? I think it's not necessary.
Contributor
Author
There was a problem hiding this comment.
Good catch, will remove this check for a_max for bounded_relu.
Contributor
|
Is there performance data for fusion? |
TaoLv
approved these changes
Aug 21, 2019
pengzhao-intel
approved these changes
Aug 22, 2019
Contributor
pengzhao-intel
left a comment
There was a problem hiding this comment.
LGTM and merging now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is to add the support for fullyconnected and some element-wise (including activation/square/sqrt/exp/abs/clip) ops fusion.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments
@pengzhao-intel @TaoLv @ZhennanQin