Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Numpy dispatch test of ......#16422

Merged
reminisce merged 3 commits intoapache:masterfrom
hgt312:hgt_np_test
Oct 19, 2019
Merged

Numpy dispatch test of ......#16422
reminisce merged 3 commits intoapache:masterfrom
hgt312:hgt_np_test

Conversation

@hgt312
Copy link
Contributor

@hgt312 hgt312 commented Oct 10, 2019

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@hgt312 hgt312 force-pushed the hgt_np_test branch 2 times, most recently from 9752b8e to 4c06615 Compare October 11, 2019 03:19
@hgt312 hgt312 marked this pull request as ready for review October 14, 2019 05:41
@hgt312 hgt312 requested a review from szha as a code owner October 14, 2019 05:41
@hgt312 hgt312 force-pushed the hgt_np_test branch 6 times, most recently from c5fe009 to ad09536 Compare October 18, 2019 04:04
@hgt312 hgt312 mentioned this pull request Oct 18, 2019
Open
hgt312 and others added 2 commits October 19, 2019 00:01
@hgt312 @reminisce
abs
e0e7e04 
arctan2

argmax

around

broadcast_to

cbrt

handel NaN

clip

copysign

degrees

equal

disable 'equal' now

dot

`fix`

flip

hypot

lcm

ldexp

inner

sqrt

square

add true_divide and its test

remove 'equal'

slightly fix 'unique' and add its test

sum

fix bug of 'take' and add its test

support py2

fix lint

try to pass ci

change variable name
@reminisce
Refactor interoperability test
f94dfb0
@reminisce reminisce merged commit b583059 into apache:master Oct 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@szha szha Awaiting requested review from szha szha is a code owner

Assignees

No one assigned

Labels

Numpy

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hgt312 @reminisce